Fix broken translation guide links in the i18n README - #71179
Open
kutsibalci wants to merge 1 commit into
Open
Conversation
The locale guideline table links to .github/skills/airflow-translations/locales/<locale>.md, but .github/skills/airflow-translations is a symlink to .agents/skills/airflow-translations. Git stores it as a symlink blob and GitHub does not traverse it, so every one of those twenty links returns 404 in the web UI. Point them at .agents/skills/airflow-translations/locales/, where the files actually live. The prose above the table named the same unreachable location, so it is updated to match.
kutsibalci
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 5, 2026 13:06
boring-cyborg
Bot
added
area:translations
area:UI
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
bbovenzi
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The locale guideline table in
airflow-core/src/airflow/ui/public/i18n/README.mdlinks to.github/skills/airflow-translations/locales/<locale>.md. All twenty of those links return 404 on GitHub..github/skills/airflow-translationsis a symlink to../../.agents/skills/airflow-translations. Git stores it as a symlink blob rather than a tree, and GitHub does not traverse it when resolving a path, so anything through it is unreachable in the web UI.This is verifiable against the API on
main:So the fix is to point the table at
.agents/skills/airflow-translations/locales/, where the files actually are. Both the link target and the visible text are updated, so the table keeps naming the location it sends you to.The prose above the table ("The PR for a new locale should include: A locale-specific translation guide file at ...") named the same unreachable path. Since a new guide cannot be added under a symlink anyway — it has to be created in
.agents/skills/airflow-translations/locales/— that line is updated too. It is one line, in the same file and the same section, describing the same location.Note
.agents/skills/airflow-translations/SKILL.mdalready carries an equivalent table and links correctly, as[locales/ar.md](locales/ar.md), because it sits next to the directory. Only the copy of the table in the i18n README was affected.What was not touched
README.mdat the repo root links to.github/skills/magpie-setup/— that is a link to the symlink rather than through it, and the surrounding text deliberately describes that path as the committed framework artefact. It behaves differently and looked like a separate call, so I left it alone.Testing
main; none now resolves through a symlinked path component, and none is missing..githuband.agentsare both seven characters, so the markdown table alignment is byte-for-byte unchanged.trailing-whitespace,end-of-file-fixerandmixed-line-endinghooks: no trailing whitespace, no CRLF, trailing newline present. The change is a like-for-like string swap inside existing links and inline code, somarkdownlintsees no structural change.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines
I ran the link sweep and drafted this description with the tool, and I reviewed the result before opening: the symlink behaviour was confirmed against the GitHub API rather than assumed, the replacement path was confirmed to serve, and the one related link I chose not to change is called out above.